Merge pull request #8 from MattitjaAB/cleanup

Cleanup

database/factories/ModelFactory.php

@@ -1,19 +0,0 @@
-<?php
-
-namespace MattitjaAB\LaravelPlausibleProxy\Database\Factories;
-
-use Illuminate\Database\Eloquent\Factories\Factory;
-
-/*
-class ModelFactory extends Factory
-{
-    protected $model = YourModel::class;
-
-    public function definition()
-    {
-        return [
-
-        ];
-    }
-}
-*/

database/migrations/create_plausible_proxy_table.php.stub

@@ -1,19 +0,0 @@
-<?php
-
-use Illuminate\Database\Migrations\Migration;
-use Illuminate\Database\Schema\Blueprint;
-use Illuminate\Support\Facades\Schema;
-
-return new class extends Migration
-{
-    public function up()
-    {
-        Schema::create('laravel_plausible_proxy_table', function (Blueprint $table) {
-            $table->id();
-
-            // add fields
-
-            $table->timestamps();
-        });
-    }
-};

phpstan.neon.dist

@@ -6,7 +6,6 @@ parameters:
     paths:
         - src
         - config
-        - database
     tmpDir: build/phpstan
     checkOctaneCompatibility: true
     checkModelProperties: true

routes/api.php

@@ -1,35 +1,6 @@
 <?php
 
-use Illuminate\Http\Request;
-use Illuminate\Support\Facades\Http;
 use Illuminate\Support\Facades\Route;
-use Illuminate\Support\Facades\Validator;
+use MattitjaAB\LaravelPlausibleProxy\Http\Controllers\PlausibleEventApiController;
 
-Route::post('api/event', function (Request $request) {
-    $data = json_decode($request->getContent(), true);
-
-    if (json_last_error() !== JSON_ERROR_NONE) {
-        return response()->json(['error' => 'Invalid JSON format'], 422);
-    }
-
-    $validator = Validator::make($data, [
-        'n' => 'required|string',
-        'u' => 'required|url',
-        'd' => 'required|string',
-        'r' => 'nullable|url',
-        'm' => 'nullable|string',
-        'p' => 'nullable|array',
-    ]);
-
-    if ($validator->fails()) {
-        return response()->json(['status' => 'error', 'errors' => $validator->errors()], 422);
-    }
-
-    $headers = collect($request->headers->all())
-        ->mapWithKeys(fn ($value, $key) => [$key => is_array($value) ? implode(', ', $value) : $value])
-        ->all();
-
-    Http::withHeaders($headers)->post(config('plausible-proxy.domain').'/api/event', $data);
-
-    return response()->json(['status' => 'queued']);
-});
+Route::post('api/event', PlausibleEventApiController::class);

routes/web.php

@@ -1,34 +1,6 @@
 <?php
 
-use Illuminate\Support\Facades\Cache;
-use Illuminate\Support\Facades\Http;
 use Illuminate\Support\Facades\Route;
+use MattitjaAB\LaravelPlausibleProxy\Http\Controllers\PlausibleScriptProxyController;
 
-Route::get('/js/script.js', function () {
-    $plausibleDomain = config('plausible-proxy.domain');
-
-    if (Cache::has('plausible_script_js')) {
-        return response(Cache::get('plausible_script_js'))
-            ->header('Content-Type', 'application/javascript')
-            ->header('Cache-Control', 'public, max-age=86400');
-    }
-
-    $response = Http::timeout(5)->get("{$plausibleDomain}/js/script.js");
-
-    if ($response->successful()) {
-        $script = $response->body();
-        Cache::put('plausible_script_js', $script, now()->addHours(6));
-
-        return response($script)
-            ->header('Content-Type', 'application/javascript')
-            ->header('Cache-Control', 'public, max-age=86400');
-    }
-
-    return response('Error fetching Plausible script', 500);
-});
-
-Route::get('/api/routes', function () {
-    return response()->json(
-        collect(Route::getRoutes())->map(fn ($route) => $route->uri())
-    );
-});
+Route::get('/js/script.js', PlausibleScriptProxyController::class);

src/Commands/LaravelPlausibleProxyCommand.php

@@ -1,19 +0,0 @@
-<?php
-
-namespace MattitjaAB\LaravelPlausibleProxy\Commands;
-
-use Illuminate\Console\Command;
-
-class LaravelPlausibleProxyCommand extends Command
-{
-    public $signature = 'laravel-plausible-proxy';
-
-    public $description = 'My command';
-
-    public function handle(): int
-    {
-        $this->comment('All done');
-
-        return self::SUCCESS;
-    }
-}

src/Facades/LaravelPlausibleProxy.php

@@ -1,16 +0,0 @@
-<?php
-
-namespace MattitjaAB\LaravelPlausibleProxy\Facades;
-
-use Illuminate\Support\Facades\Facade;
-
-/**
- * @see \MattitjaAB\LaravelPlausibleProxy\LaravelPlausibleProxy
- */
-class LaravelPlausibleProxy extends Facade
-{
-    protected static function getFacadeAccessor(): string
-    {
-        return \MattitjaAB\LaravelPlausibleProxy\LaravelPlausibleProxy::class;
-    }
-}

src/Http/Controllers/PlausibleEventApiController.php

@@ -0,0 +1,22 @@
+<?php
+
+namespace MattitjaAB\LaravelPlausibleProxy\Http\Controllers;
+
+use Illuminate\Http\JsonResponse;
+use Illuminate\Support\Facades\Http;
+use MattitjaAB\LaravelPlausibleProxy\Http\Requests\PlausibleEventRequest;
+
+class PlausibleEventApiController
+{
+    public function __invoke(PlausibleEventRequest $request): JsonResponse
+    {
+        $headers = collect($request->headers->all())
+            ->mapWithKeys(fn ($value, $key) => [$key => implode(', ', $value)])
+            ->all();
+
+        Http::withHeaders($headers)
+            ->post(config('plausible-proxy.domain').'/api/event', $request->validated());
+
+        return response()->json(['status' => 'queued']);
+    }
+}

src/Http/Controllers/PlausibleScriptProxyController.php

@@ -0,0 +1,38 @@
+<?php
+
+namespace MattitjaAB\LaravelPlausibleProxy\Http\Controllers;
+
+use Illuminate\Http\Client\RequestException;
+use Illuminate\Http\Response;
+use Illuminate\Support\Facades\Cache;
+use Illuminate\Support\Facades\Http;
+use Illuminate\Support\Facades\Log;
+
+class PlausibleScriptProxyController
+{
+    public function __invoke(): Response
+    {
+        try {
+            $script = Cache::remember(
+                key: 'plausible_script_js',
+                ttl: now()->addHours(6),
+                callback: function () {
+                    $plausibleDomain = config('plausible-proxy.domain');
+
+                    return Http::timeout(5)
+                        ->get("{$plausibleDomain}/js/script.js")
+                        ->throw()
+                        ->body();
+                }
+            );
+        } catch (RequestException $e) {
+            Log::error('Failed to fetch Plausible script: '.$e->getMessage());
+
+            return response('Error fetching Plausible script', 500);
+        }
+
+        return response($script)
+            ->header('Content-Type', 'application/javascript')
+            ->header('Cache-Control', 'public, max-age=86400');
+    }
+}

src/Http/Requests/PlausibleEventRequest.php

@@ -0,0 +1,25 @@
+<?php
+
+namespace MattitjaAB\LaravelPlausibleProxy\Http\Requests;
+
+use Illuminate\Foundation\Http\FormRequest;
+
+class PlausibleEventRequest extends FormRequest
+{
+    public function authorize(): bool
+    {
+        return true;
+    }
+
+    public function rules(): array
+    {
+        return [
+            'n' => ['required', 'string'],
+            'u' => ['required', 'url'],
+            'd' => ['required', 'string'],
+            'r' => ['nullable', 'url'],
+            'm' => ['nullable', 'string'],
+            'p' => ['nullable', 'array'],
+        ];
+    }
+}

src/LaravelPlausibleProxy.php

@@ -1,5 +0,0 @@
-<?php
-
-namespace MattitjaAB\LaravelPlausibleProxy;
-
-class LaravelPlausibleProxy {}

tests/PlausibleProxyTest.php

@@ -46,7 +46,7 @@ it('rejects invalid event data', function () {
     ]);
 
     $response->assertStatus(422)
-        ->assertJsonStructure(['status', 'errors']);
+        ->assertJsonValidationErrors(['u' => 'The u field must be a valid URL.']);
 });
 
 it('accepts valid event data and forwards headers', function () {